Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

e35d1254e760...
Jane Sandberg
Stamp upgrade script for MADS update
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
d436f5b4a409...
Jason Boyer
Test Followup: Fix Jacket Dir in autogen.sh
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
ce0d2f4ab79a...
blake
LP1944205 Advanced Authority Documentation
Added a new document authorities_advanced.adoc

Integrated to the nav

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Lynn Floyd <alynn2671@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
c65b3f8f466b...
Bill Erickson
LP1930740 EDI order writer attribute check repair
Repairs mistaken references to $self->{compiled}->{edi_attr}...  The
hash key we need is {edi_attrs}.

This issue prevented these attribute types from getting applied:

LINEITEM_IDENT_VENDOR_NUMBER
COPY_SPEC_CODES
INCLUDE_EMPTY_LI_NOTE

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
b5eb3fe1d3a2...
Mike Rylander
LP#1967770: Followup fix for cover image directories
In the initial fix we checked for the top level cover image location and
error out if it's not there, but this is unnecessary since it will be
created if it doesn't yet exist.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
ab5478b879e9...
Bill Erickson
LP1956626 Copy editor loads all needed copy locations
The item-location-select component now allows the caller to pass in a
set of context org unit IDs (in lieu of just a single id) for loading
copy locations across different areas of the org unit tree (without
having to load *all* copy locations).

Changes applied to the Angular copy location editor to pass the needed
context org units to the item location select component.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
934adda92f56...
Andrea Buntz Neiman
Docs: updates to 3.9 release notes
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
92eb8b8f0030...
Terran McCanna
LP1958265 Angular Holds Grids Not Printing Barcode
This adds the ability to print (or download CSV) the Current Item
and Requested Item barcodes from the Holds Pull List and from the
Holds tab of the bib record.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
90abcab3ce2b...
Garry Collum
LP1958163 Bootstrap Opac: the 'Request a Card' link.
This fixes the 'Request a Card' link which displays in the bootstrap opac
regardless of the 'Allow Patron Self-Registration' library setting in both
the login page and the login modal.

To Test:
1. Click on My Account in the Bootstrap Opac to open the login modal.
  Notice the Request a Card link.  Click Login without adding a barcode
  or pin# to see the login page with its link.
2. Set the Allow Patron Self_Registration library setting to false for the
  Consortium.
3. Repeat 1, and notice that the link still displays.
4. Apply the patch.
5. Now the link should not be visible in both forms.
6. Set the library setting to true, to verify that the link does display.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
8e0b1657e196...
Jason Etheridge
LP#1965579: stop gap for negative bills in OPAC
(and zero bills).

If a patron has zero-dollar or negative bills present, the OPAC will
disallow payment and point the patron to their library to resolve.

Cribbed from Terran's rel_3_8_0_temp_fix_for_stripe_negative_bill_bug @ evergreen/pines.git

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8cba22af6dd2...
Andrea Buntz Neiman
Docs: Simple Reports docs
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
8b23aae57552...
Mike Rylander
Docs: OAI-PMH data provider support
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
8b0ed0b9391f...
Jason Boyer
LP1915816: Add test output to .gitignore and track package-lock.json
Just what it says on the tin.

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
8635c3188fb1...
Jane Sandberg
LP1915816 follow-up: update package-lock.json
83b92e26b525...
Galen Charlton
fix a syntax warning in the 3.9 release notes
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
824a83aed33c...
Mike Rylander
Base 3.9 release notes
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7a57a199ecf4...
Jeff Davis
LP#1966802: add Matomo support to Bootstrap OPAC
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
77c87edab180...
Mike Rylander
Translation updates - newpot
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7687f572fb30...
Jason Stephenson
LP1959904: Fix Angular Profile Select Component
The Angular profile select component has a bug when permission group
tree display entries are used.  It will loop forever if the grp and
parent have the same value in permission.grp_tree_display_entry
because it is comparing permission group tree entries to permission
group tree display entries in the groups filter of the grpLabel
function.

This patch adds a ternary operator to compare display entries to
display entries and group tree entries to group tree entries in a
manner identical to how the parent value is determined a few lines
above.

See the bug description for more information:

    https://bugs.launchpad.net/evergreen/+bug/1959904

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
70f5308b4c96...
Mike Rylander
Translation updates - po files
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6eb549a931c8...
Jason Etheridge
LP1950826 fix invalidate email action
and other invalidate contact actions

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
64331490cc4f...
Galen Charlton
LP#1950468: make Replace Barcode from Item Status detect duplicate barcodes
This patch makes the Replace Barcode action when invoked from
Item Status properly detect and warn if the replacement barcode
is a duplicate of one already found in the system. This is a complement
to the fix for bug 1890498.

To test
-------

[1] Enter an item barcode into Item Status.
[2] Try 'Replace Barcode' from detail view and set the
    replacement barcode to one that is already active in
    Evergreen. Note that the dialog closes without
    updating the barcode or warning about the duplicate and
    that a error is logged in the browser console.
[3] Repeat step 2, but this time from list view. Note
    the problem remains the same.
[4] Apply the patch and repeat steps 2 and 3. Note that
    now the dialog will remain open and will display an
    error message complaining about the duplicate barcode.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Erica Rohlfs <erica.rohlfs@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
63c33ee6ee95...
Garry Collum
LP#1942240 Insufficient color contrast in boostrap forms
Overrides the bootstrap form-control border color. Also changes the
border_standard color in colors.tt2 which is used for the border
around some form elements.

After this patch is applied the color ratio is 3.54:1

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
63a3558b3aad...
Josh Stompro
LP#1800871 - MARC21slim2MADS 2.15 update
This update fixes an error when trying to process a 755 tag in
and authority record that has a source set.

See the discussion on the listserv at:
https://georgialibraries.markmail.org/thread/rmwcxkwjzv2qczmu

To test, try to import the sample authority record provided
by Linda Jansova (https://markmail.org/thread/2ay3j4wg7fecymhz)
in evergreen, and see the log files for the import errors.

It is also possible to test from the command line.

In /openils/var/xsl, copy the example autority marc xml file to
that directory, name it americ.xml, then run the command
xsltproc ./MARC21slim2MADS.xsl ./americ.xml

This will error out.

After patch has been applied, try importing the sample authority
record and see that it imports successfully.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
5a808f19768d...
Bill Erickson
LP1969232 Use fonts-only material icon fonts package
This replaces the larger package which caused 'npm install' to take a
very long time to complete.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
579cbf60090c...
Bill Erickson
LP1958265 Holds grid barcode print/csv fix
Tweak the barcode print/csv logic to populate the current_item and
requested_item values using the same logic as the grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
529e4f725bba...
Andrea Buntz Neiman
Docs: further updates to 3.9 release notes
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
4f1a4030660e...
Garry Collum
LP1907863 Bootstrap Opac: My Lists formatting
This patch moves the buttons for each list row underneath the title and descriptions fields.
It makes the create list form collapsible using a button.
If there are lists, the create form is collapsed.
The create form is expanded on load, if the user selects move bucket to new list, or add rec to new list from a menu or button from another page.
The "Move contents of basket to this list?" in the creation form now defaults to 'yes' if an option to move a basket to a new list is chosen from a menu.
It adds localization functions to the button texts and removes a dangling </div> in anon-list.tt2
It moves the create form from a <table> design and uses Bootstrap elements instead.

To Test.

1. After applying the patch view the list page and notice that the form is expanded.
2. Create a list.  The form is now collapse.
3. Perform a search and add some of the titles to a basket.
4. From one of the result rows drop-down the Add to My List menu and select 'Add to New List'.
  The form is expanded and the "Move contents of basket to this list" should be 'yes'.
5. From the basket screen or from the lists screen click on the 'Add to New List' button.  The results should be the same as step 4.
6. After creating a few lists, notice that the buttons for each list are now displayed under the list title and description and
  each row is distinguished by a bottom border.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
4d25e4865a35...
Mike Rylander
Forward port 3.9 upgrade script
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4471aee9b6f4...
Jason Boyer
LP1915816: Bonus commit - Remove Old .gitignore Entries
There are a few things that were being ignored that could no longer
really exist anyway, so we may as well clear some out.

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
42eddc6429a7...
Galen Charlton
LP#1970469: fix responses streamed out of order due to chunking
If a streaming method starts off sending a couple small responses
followed by a large one, the responses can end up received out of
order under this scenario:

- The initial small responses get stashed to be sent out as a bundle
- The large response, if big enough to require chunking, gets sent
  out as a set of partial responses. However, any messages queued
  up to go out as a bundle remain in the queue.
- When the method completes, or if further responses result in
  exceeding the maximum bundle size, the queued messages get sent
  _after_ the chunked response.

This affects services written in C and Perl.

To test
-------

C service
=========
[1] Add the following stored procedure to an Evergreen database:

CREATE OR REPLACE FUNCTION public.lp1970469_sample() RETURNS SETOF TEXT AS $$
BEGIN
    RETURN NEXT 'abc';
    RETURN NEXT 'def';
    RETURN NEXT rpad('long', 65000, 'x');
    RETURN NEXT 'xyz';
    RETURN;
END;
$$ LANGUAGE PLPGSQL IMMUTABLE;

[2] Run the following srfsh command:

srfsh# open-ils.cstore open-ils.cstore.json_query.atomic {"from":["public.lp1970469_sample"]}

[3] Note that longxxxxx* response is returned first, followed by abc,
    def, and xyz.
[4] Apply the patch and repeat step 2. This time, the responses should
    be returned in the expected order.

Perl service
============
[1] In an Evergreen database, attach a couple hundred items to
    a record.
[2] Run the following srfsh command:

srfsh# request open-ils.supercat open-ils.supercat.record.holdings_xml.retrieve BIBID, "-", null, 1

[3] If enough items were attached, the first response streamed will
    start with a <volume> element rather than the <holdings> element
    and the overall response will not be well-formed XML.
[4] Apply the patch and repeat step 2. This time, the parts of the
    response should be in the expected order.

Note that this test scenario models an Evergreen glitch seen in the
wild that causes requests for

https://EGSERVER//opac/extras/supercat/retrieve/marcxml-full/record/BIBID

to fall if there are a lot of items attached to the bib.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
42a6947407a8...
Mike Rylander
Correct jacket uploader upgrade script
Signed-off-by: Mike Rylander <mrylander@gmail.com>
38dadde8877b...
Jane Sandberg
LP1800871: small correction to upgrade script
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3663817ec8c9...
Dan Briem
LP#1965317 Barcode Completion on Traditional Cat Staff Holds
This allows the completed barcode to populate in the barcode
input when the hold group interface isn't rendered.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2d76a732f3e2...
Bill Erickson
LP1950826 Return error result on contact invalidation
If penalty creation fails, return the error/event response to the caller
instead of the editor's last event.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
27d6cc9ab496...
Galen Charlton
LP#1970486: fix SuperCat crash on serial units with stat cats
This patch fixes a bug where retrieving a title via SuperCat (in
particular, with holdings XML) can crash of the title has a serial
unit (i.e., barcoded serial item) attached that also has a statistical
category.

To test
-------
[1] Create a title with a barcoded serial item.
[2] Attempt to fetch the title via SuperCat:

https://EGSERVER/opac/extras/supercat/retrieve/marcxml-full/record/BIBID

[3] Note that an internal server error is returned.
[4] Apply the patch and repeat step 2. This time, an XML
    document should be returned that includes the serial item
    and its stat cat.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
1f67996b4534...
Andrea Buntz Neiman
Docs: adding rel_3_9 menu item
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
1d25efcefd23...
Galen Charlton
clear miscellaneous.adoc for next release
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
1623d146d03c...
Josh Stompro
LP#1778783 - Circulate.pm fix log_me correct barcode var
The log_me sub wasn't using the correct variable for showing the entered
barcode.  It should be $self->copy_barcode instead of $self->barcode.

Testing Notes:

Before fix:
1. Watch the logs with something like
  tail -f osrfsys.log | fgrep 'circulator: do_permit()'
2. Perform a checkout of a non-existant barcode.
3. Notice that the entered barcode is missing after 'copy='

After fix:
1. Restart the circ openils service
  osrf_control -l --service open-ils.circ --restart
2. Watch the logs.
3. Perform a checkout of a non-existant barcode.
4. Notice that the barcode is now shown after 'copy='

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
02fd78a79f6f...
Jane Sandberg
LP1915816 follow-up: one more .gitignore addition
Suggestion from Shula Link.  Thanks, Shula!

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Co-authored-by: Shula Link <slink@gchrl.org>