Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

f9d445a511b5...
Clayton Liddell
LP#1908455 - Prevent multiple server processes
Check for the existence of a server process before creating a new
server process in oils_ctl.sh.

Signed-off-by: Clayton Liddell <clayton@librarymarket.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
f61da4f5e00e...
Galen Charlton
LP#1978978: add release notes entry
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
f5c8a9715d06...
Dan Briem
LP#1945355 Inconsistent button placement: delete holdings dialog
The cancel button on the delete-volcopy-dialog now appears last
to be consistent with the eg-confirm dialogs.

To test:
1. set the ou setting "Alert on empty bib records" to true
2. delete the last copy on a record
3. note the Delete Holdings/OK and Cancel buttons are in the
  same order on the delete and confirmation dialogs

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
f47267e04061...
Garry Collum
LP1965065 Example DOB on self-registration displays twice
This fixes the double display of the example text in the self-registration form of the opac.
Not only does DOB example display twice but the example text for phone, email, and
postal code also display twice.

To test:
1. Go to library settings and set "Allow Patron Self Registration" and "Show DOB field on patron
registration" to true.  Set a value for "Example dob field on patron registration".  If testing
phone, postal code, or email the appropriate values must be set for the show and example
parameters.
2. Go to "Request a Library Card" in the opac.
3. Notice that the DOB example displays twice.
4. Apply the patch.
5. The example now just displays once.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
f25a658e5001...
Jane Sandberg
LP1999304 (follow-up): blank alt text for decorative image
Steps to test:
1. Search the staff catalog for Ready Player One in the concerto dataset.
2. Check the Group Formats/Editions checkbox
3. Press the Place hold button
4. Use your browser's dev tools (or a screen reader) to find the accessible
name of the Large Print Book checkbox.
5. Confirm that the accessible name is Large Print Book, rather than
Large Print Book Large Print Book.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
e91f2837865f...
Stephanie Leary
LP1999954 Modal header color contrast fixes
Changes modal header and close button to white in order to pass WCAG
color contrast checks.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
e81a0d0b671e...
Galen Charlton
LP#1976126: (follow-up) update method documentation
This patch updates the open-ils.actor.patron.update method
documentation to explicitly state that updates to patron notes,
user activity, and standing penalities via that method are
ignored. This is to try to avoid a regression on this bug, as
otherwise it might be plausible for the method to allow the notes
and standing penalties (at least) to be updated.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
e59899c0fe2f...
Stephanie Leary
LP1999304 Labels for metarecord hold checkboxes
Wraps metarecord hold format and language checkboxes in labels with
for attributes matched to input IDs.

To test:

1. Search the catalog for an item with multiple formats
2. Check the option to group formats/editions
3. Click "place hold" on one of the results
4. Find the table below "Placing METARECORD hold on record(s)"
5. Toggle the language or format checkboxes by clicking their labels or
  icons rather than the box itself

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
d9c24951f096...
Galen Charlton
LP#1978978: stamp schema update
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
d1d45fdd5747...
Bill Erickson
LP1995623 Ang checkout prevents due dates in the past
Prevent previous date selection in due date selector.

Additionally warn when a time in the past on the current day selected
and prevent checkout submission.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
cfc5b8a048de...
Garry Collum
LP1980304 Bootstrap: Facets move when viewing results for grouped records.
Fixes the displacement of the facets in the bootstrap opac when viewing grouped records.

To test:
1. Perform a search in the bootstrap opac with the Group Formats and Editions option
selected.  In concerto - "Ready Player One"
2. Click on a resulting title that contains more than one format.
3. Notice the placement of the facets.
4. Apply the patch and repeat.
5. The facets should no longer be displaced when viewing metarecords or non-metarecords.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
c70bde9b34bf...
Garry Collum
LP1422927 Opac hold history pagination
Fixes the hold history pagination in both the TPac and the Bootstrap opac.

To test:
1. Login as a patron and enable the hold history preference.  The default
number of items on each page is 15, so place at least 16 holds for this
patron.  (The limit can be overridden in the url with the &limit switch).
2. View the hold history and notice that all items are displaying on all
pages.
3. Apply the patch
4. The results are now paginated with 15 items per page.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
c54f13165a5c...
Garry Collum
LP#1984269: Bootstrap opac: display of tables on small screens
This incorporates a generic process to display vertical tables in the Bootstrap
opac in small screens by adding a 'mobile-title' attr to any <td> elements
of the table.  This patch uses the copy_table.tt2 and results/table.tt2
as examples.

These two tables are best tested with bibs that contain items that have parts.
The results/table.tt2 is displayed by using the "Show More Details" button
on the results screen.  When the screen is sized so that the tables become
vertical the parts column is not displayed.  After the patch is applied
the parts column is displayed only on those bibs that contain parts.

For these two particular tables, it also refactors the method
in which the copies are numbered with the lists.  Prior to the patch the
mobile display would show the copy number, but it would stop at 10 for both
of these tables, because that's what was defined in CSS.  They should now
display a number for each table row displayed.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
c3de377e1650...
Jane Sandberg
LP#1955079: Use Email::MIME for emailing records in the OPAC
Email::Simple was mangling the headers.  Let's use Email::MIME instead.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
c1aca3b696a9...
Mike Rylander
LP#1976126: Don't send useless (big) user data
When saving a user in the AngularJS UIs, we currently send the notes,
usr_activity, and standing_penalties fields to the actor service.
However, that's not how those get updated, and with large sets that can
cause problems.  This commit removes those fields before saving the
user.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
bebcbf27ba03...
Jason Boyer
Forward Port 3.8.2 Upgrade Script
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
a75416d39934...
Galen Charlton
LP#1998386: add release notes entry
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
a4809bac53a2...
Bill Erickson
LP1995623 DateTime picker gets min/max date support
Note this only affects the date select, since the time picker has no
notion of a minimum time.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
9f1ab420c377...
Galen Charlton
LP#1995623: stamp schema update
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
9761c1c8047f...
Terran McCanna
LP1998386 Add Report Template ID to Interface
This displays the report template id in the staff client
under Reports > Templates to aid in troubleshooting reports
questions.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8326611f8dc2...
Andrea Buntz Neiman
Docs: updating Global Flags docs
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
82fcd07434d0...
Stephanie Leary
LP1999446 Localize "Record Summary" card heading
Wraps the bib summary card heading in a span for localization.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
79c3b38883fd...
Garry Collum
LP1966995: Bootstrap Opac: fix display of 856 $n, $z, and $3
This fixes the display in the Bootstrap Opac for the 856 subfields n, z, and
3.

To test:

1. Create a record(s) with 856 fields which contain a combination of
subfield n, z and 3's.
2. Prior to the patch the fields do not display in the bootstrap opac.
3. Apply the patch.
4. The fields will now display.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Carol Witt <wittc@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
74283309bde3...
Andrea Buntz Neiman
Docs: updates to Standing Penalties and Group Penalty Thresholds
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
6b0608fe65f2...
Rogan Hamby
LP#1978978: Remove public flag from biblio.record_note
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
6193f9644d12...
Garry Collum
LP1980302 Bootstrap: applied search filters display oddly
Moves the display of applied filters into bootstrap alert messages and aligns applied filters
in a row, and utilizes more native bootstrap classes.  Also, adds a label to the 'Locations'
filter and code to implement an 'OR' separator, if more than one location is selected.

To test:
1. Perform an advanced search in the bootstrap catalog and apply some filters. To test
the locations, select several location options.
2. Notice the formatting of the 'Filtered by:' display data.  Notice also the display
of the locations filter without a label or a separator.
3. Apply the patch.
4. Repeat 2 to see the new formatting.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
5eca8123787b...
Adam Woolford
LP19800544 Import all holdings templates
Adds loop to importTemplate function so that the whole file will import

Signed-off-by: Adam Woolford <adam.woolford@hotmail.com>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
5b7d750cd7f1...
Jessica Woolford
LP 1999696 - Saving stat cats and values in holdings templates
Updating the saveTemplate function so that is consults statCatValues

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
526ac8856ea7...
Scott Angel
LP1974581 Publication Year Filter Fields Out of Alignment
Added 5px margin to the top of the <select> dropdown.

Signed-off-by: Scott Angel <scottangel@mobiusconsortium.org>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4bdd45c15988...
Andrea Buntz Neiman
Docs: web services docs fix
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
4b17f3dc3541...
Mike Rylander
LP#1955079: Staff catalog can't email records
The angular staff catalog uses the new print/email records
functionality, but calls it without some expected parameters.  This
causes the backend method to fail as it assumes the params will exist.

This commit removes that assumption by testing the length of the
parameter list before attempted to read them.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
48774e526a2d...
Garry Collum
LP#1983729: Bootstrap Opac: fix copy navigation links in small screens
This moves the previous, next, and Show more copies links out of the
copies table so that these values do not have incorrect labels on small
screens.

To test:
1. Retrieve a bib record with a large number of copies.
2. In a small screen notice that the previous, next, and show more copies
links are labeled, as Library and Call Number.
3. Apply the patch.
4. Repeat step 2.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3f7b48566d3f...
Andrea Buntz Neiman
Docs: global flags docs fixes
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3beab57e78f6...
Andrea Buntz Neiman
Docs: 3.10 Antora update
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
365e6c38f520...
Stephanie Leary
LP1948693 Migrate from NgbTabset to ngbNav
Updates the deprecated NgbTabset components to ngbNav and adds directive
for keyboard navigation.

See https://gist.github.com/stephanieleary/800b9f2b1d9c08cc66d694daaa1788b9 for
a quick guide to the markup changes involved.

Screens to test:

1. /staff/acq/provider, right click an existing provider to show details tabs
2. /staff/admin/local/negative-balances
3. /staff/admin/local/action/survey, edit an existing survey, test Edit Survey
and Q&A tabs
4. /staff/admin/server/actor/org_unit, note that Addresses tab has a second set
of tabs underneath
5. /staff/admin/server/actor/org_unit_type, note that eg-tree has also changed
here
6. /staff/admin/server/permission/grp_tree, choose a group to see tabs
7. /staff/admin/server/config/print_template
8. /staff/booking/create_reservation
9. /staff/booking/manage_reservations, filter reservations section
10. /staff/booking/return
11. /staff/cat/authority/browse
12. /staff/cat/vandelay/import and all import/export tabs
13. /staff/cat/bucket/record/view
14. /staff/catalog/search
15. /staff/circ/holds/pull-list, right click a hold, choose Show Hold Details,
the tabs are at the bottom of the screen

Test plan:

Note that you cannot navigate tabbed interfaces using the tab key on your
keyboard.

Apply the patch, then visit the screens listed above.

You should be able to use the tab key to move sequentially through all the tabs.
Pressing Enter on an inactive tab should make it active, just as clicking it
would. You should not be able to click or press Enter to activate a disabled
tab.

You should be able to move from the last tab in the list into the first
focusable element in the active tab's content panel. If you spot a tab content
panel that doesn't contain a focusable element (i.e. links or inputs), let me
know; we have to set its tabindex attribute manually.

If a tab panel contains a second set of tabs, these should work as well.

Note on ARIA and roles:

Note that neither Bootstrap 5 nor ng-bootstrap are currently following the ARIA
Authoring Practices Guide for tabs with manual activation (the recommended
pattern for tab panels with complicated content, like form inputs or data
tables), which does not recommend sequential movement:
https://www.w3.org/WAI/ARIA/apg/example-index/tabs/tabs-manual.html. Therefore,
we aren't following this pattern either. We can revisit this and/or take it up
with Bootstrap.

For now, running axe DevTools on any screen with navs will show ARIA role errors
on role="tab" attributes. We are using ng-bootstrap's default ARIA roles for
tabs, but they are incorrect. I am trying to get traction on a pull request to
change the problem in ng-bootstrap, but in the meantime, we are not using the
automatic [roles] directive. Role attributes have been set explicitly on all
tabs and their containing elements.

Note on eg-tree CSS:

In the Org Unit Type screens, there was previously some inline CSS related to
eg-tree that was causing compiler errors. I have moved this to a separate CSS
file, and will revisit eg-tree styles more generally in another upcoming
project.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2f5e6f4721ae...
Bill Erickson
LP1995623 Patron data print template repairs
Patron alert_message field is no more.  Remove it from the default
patron data print template.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2ca151971be6...
Galen Charlton
Docs: Evergreen web services docs
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
142a51bb71a8...
Tiffany Little
LP1995418 Shelving location selector won't dropdown
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
13a3954f9a71...
Galen Charlton
LP#1978978: (follow-up) remove pub from CDBI class
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
06dd3972f5b0...
Garry Collum
LP1992490-Bootstrap Opac: sr-only, aria-label, and title localization.
Corrects some instances of non-localization of sr-only fields, aria-labels,
and title attributes.  Also corrects some stray display strings that were
not localized.

To test:

Apply the patch, and view each page to see if it renders. View the page
source of each page to see if the sr-only fields, aria-labels, and
title attributes are rendered correctly.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>