Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Failed Again Running Exception Offline No data

fe474209a567...
a. bellenir
LP#1775216: adding a pgtap test for inconsistent availability counts
Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
fdd829da38d9...
Bill Erickson
LP#1770981 Apply OpenSRF locale on webstaff page load
Translate the locale from the locale cookie into the global
OpenSRF.locale variable so network calls are stamped with the correct
locale.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
  • evergreen-master-fedora-18: pylint failed -  stdio
ecdcfb21c141...
Garry Collum
LP#1752891 Crowded text on Print Item Labels page fix.
This patch replaces an h4 style used for labels for dropdown lists, removes a blue background, and changes the style of the title of the page. All to make this page look more consistent with other pages in Evergreen.  Also removes some unnecessary extra divs and makes the bootstrap columns for the top form more consistent.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Conflicts:
Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2
  • evergreen-master-fedora-18: pylint failed -  stdio
eac43ead53e9...
Mike Rylander
LP#1702978: memcache Remove method used in a variadic way
Related to the OpenSRF branch on this same bug, the prevents Evergreen from
using a to-be-non-variadic memcache method in that way.  This prevents issues
for memcache keys that contain a %.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
e8e766724270...
Jane Sandberg
LP1164061: Edit authority record by database ID
Allow users to jump directly to the authority record MARC edit interface
by entering the authority record ID.

Includes release notes.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
e3a67f1a81b8...
Jane Sandberg
Docs: sample patron import script now also updates existing patron data
With inspiration and help from Martha Driscoll

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
deab49ceef1b...
Galen Charlton
LP#1721575: Batch Actions In the Public Catalog
The public catalog now displays checkboxes on the bibliographic and
metarecord constituents results pages. Selecting one or more titles
by using the checkboxes will dynamically add those title to the
temporary list, which is now renamed the basket.

Above the results lists there is now a bar with a select-all checkbox,
a link to the basket management page that also indicates the number of
of titles in the basket, and a link to remove from the basket titles that
are selected on the currently displayed results page.

The search bar now includes an icon of a basket and displays the number
of titles currently in the basket. Next to that icon is a menu of basket
actions.

The basket actions available are Place Hold, Print Title Details,
Email Title Details, Add Cart to Saved List, and Clear Cart. In the
web staff client, the basket actions also include Add Cart to Bucket.
When an action is selected from this menu, the user is given an
opportunity to confirm the action and to optionally empty the basket
when the action is complete. The action is applied to all titles
in the basket.

Clicking on the basket icon brings the user to a page listing the
titles in the basket. From there, the user can select specific records
to request, print, email, add to a list, or remove from the basket.

The list of actions on the record details page now provides separate
links for adding the title to a basket or to a permanent list.

The permanent list management page in the public catalog now also
includes batch print and email actions.

Additional information
++++++++++++++++++++++
* The checkboxes do not display on the metarecord results page, as
  metarecords currently cannot be put into baskets or lists.
* The checkboxes are displayed only if Javascript is enabled. However,
  users can still add items to the basket and perform batch actions on
  the basket and on lists.
* A template `config.tt2` setting, `ctx.max_basket_size`, can be used to
  set a soft limit on the number of titles that can be added to the
  basket. If this limit is reached, checkboxes to add more records to the
  basket are disabled unless existing titles in the basket are removed
  first. The default value for this setting is 500.

Developer notes
+++++++++++++++

This patch adds the the public catalog two routes that return JSON
rather than HTML:

* `GET /eg/opac/api/mylist/add?record=45`
* `GET /eg/opac/api/mylist/delete?record=45`

The JSON response is a hash containing a mylist key pointing to the list
of bib IDs of contents of the basket.

The record parameter can be repeated to allow adding or removing
records as an atomic operation. Note that this change also now available
to `/eg/opac/mylist/{add,delete}`

More generally, this adds a way for EGWeb context loaders to specify that
a response should be emitted as JSON rather than rendering an HTML
page using `Template::Toolkit`.

Specifically, if the context as munged by the context loader contains
a `json_response` key, the contents of that key will to provide a
JSON reponse. The `json_response_cookie` key, if present, can be used
to set a cookie as part of the response.

Template Toolkit processing is bypassed entirely when emitting a JSON
response, so the context loader would be entirely reponsible for
localization of strings in the response meant for direct human
consumption.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
d967aac09b07...
Kathy Lussier
LP#1775216: Stamping upgrade script for inconsistent copy counts
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
d22f8fd2405a...
Jane Sandberg
Docs: small changes to record bucket docs
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
bf0a3fd21abd...
Bill Erickson
LP#1718032 Patron merge honors group perms; no self-merge
Ensure the staff performing a patron merge have sufficient permission to
edit all users involved in the merge process, in addition the
MERGE_USERS permssion.

Prevent staff from merging their own logged in account.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
ba5f74d896b5...
Kathy Lussier
LP#1721575: Changes to some strings
We missed one instance of cart when changing everything over to baskets. Also,
I updated language for clearing a basket after placing a hold to make it a
little clearer.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
abb351005e45...
Mike Rylander
LP#621459: Discard overlay target after merge in Z39.50 interface
Cataloger concensus is that we should discard the overlay target after a merge
is completed in order to help avoid accidental re-overlay.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
aae6a29aa9ac...
a. bellenir
LP#1785305: Item Status 'Edited By' shows id instead of username.
This commit changes Item Status 'Edited By' field to show the editor's
username to match XUL.

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
aa1d5603aacf...
a. bellenir
LP#1775216: inconsistent copy counts between opac and staff client
opac version of copy counts was including copies under deleted call numbers
more discussion here: http://irc.evergreen-ils.org/evergreen/2018-06-08#i_363334

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
9b4591e3f9f8...
a. bellenir
LP#1775216: inconsistent availability counts between staff client and opac
update asset.staff_ou_record_copy_count to get an accurate available count.

borrow asset.opac_ou_record_copy_count's logic for counting available copies
so that statuses with is_available set to 't' in config.copy_status are used
instead of using the hardcoded status id list (0,7,12)

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
91d838f48e59...
Bill Erickson
LP#1747512 Non-cat checkout fix display/print
Fixes an issue which caused an exception to be thrown during non-cat
item checkout in the browser client, preventing the checkout from being
properly displayed in the checkout page, the Items Out list, and on the
receipt.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
913237b92bcd...
Jason Stephenson
LP 1780660: Add more workstation functions to OpenILS::Utils::TestUtils.
Add methods find_or_register_workstation($name, $lib) and
find_workstation($name, $lib) to OpenILS::Utils::TestUtils.  These can
be used when writing tests or other scripts to find or create
workstations.

The following Perl live tests were updated to use the new methods
rather than their hand-rolled versions:

* 14-lp1499123_csp_ignore_proximity.t
* 18-lp1592891_sip_standing_penalties.t
* 19-lp1306666-abort-transit-copy-status.t
* 25-lp1694058-multiple-hold-placement.t

Testing this is very simple:

1. Install Evergreen from this branch.
2. Load the Concerto dataset.
3. Start Evergreen services with osrf_control.
4. cd to the perlmods source directory.
5. Do 'make livecheck' and see that all tests pass, particularly the 4
  mentioned above.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
6d98ced94170...
Bill Erickson
LP#1775719 Modify array check for Phantomjs; reduce logging;
PhantomJS doesn't support the handy [1,2,3].includes(1) function, so
replace it with the tried-and-true indexOf();

Avoid logging errors on failure to connect to the shared offline worker
when running within phantomjs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
65baf6b58639...
Ben Shum
Translation updates - newpot
Signed-off-by: Ben Shum <ben@evergreener.net>
  • evergreen-master-fedora-18: pylint failed -  stdio
6414c2527f6b...
Mike Rylander
LP#1702978: memcache Get methods use key as va_list format
And, when a key (composed of, say, a username or barcode) has a % in it,
bad things happen.  We will stop acting as if these are variadic functions
now, and also update Evergreen so that it does not do that either.

TODO: Make these actually non-variadic, but that breaks ABI.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
5b5b9cce4fc9...
Mike Rylander
LP#1739460: Be more careful when gathering shelving locations
Specifically, make sure we're getting the IDs, and comparing them as numbers.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
536e5e8cd2a4...
a. bellenir
LP#1785333: Right-click can clear grid selection
This commit uses egGrid's indexValue API to identify the clicked row rather
than depending on grid row order when checking whether the that row is
currently selected.  This is a generalized fix for all grids.

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
4e0528b11a24...
Bill Erickson
LP#1721575 Stamping DB upgrade: batch catalog actions
Also replaced a remaining reference to "cart" with "basket"

Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
327daf4e40f1...
a. bellenir
LP#1587620: inconsistent copy counts between opac and staff client for peer bibs
staff copy counts should include peer bib copies, per LP1587620.

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
1fb2209aa3ea...
Bill Erickson
LP#621459 Clear Z39 overlay target message after overlay
Reset the "Record with TCN XXX marked for overlay." message to show "No
record marked for overlay." once the overlay target is cleared after a
Z39 overlay.

Removed an errant '"' in the overlay message.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio