Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

f7fe764d8d8f...
Chris Sharp
Forward-port 3.5.1-3.5.2 version upgrade script
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
effcfc5d32f0...
Jason Boyer
LP1904220: Fix Booking Service Check
Instead of trying to tell AppService which router we want to talk
to and confusing it, just tell it we want to talk to a router and
let it do its thing.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
ef4961ce5716...
Jane Sandberg
Docs: release notes for 3.6.1
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
e7ff03cf0ae0...
Bill Erickson
LP1896285 Patron search add to bucket serialize
Add a batch of patrons to a bucket one patron at a time to avoid
overwhelming the server with bucket item create requests and potentially
exhausing the open-ils.actor service.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
e15ce41f590d...
Bill Erickson
LP1889128 Place holds honors default phone
Adds support for using the 'opac.default_phone' user setting when
placing holds in the staff catalog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
dfa5de2f6418...
Bill Erickson
LP1846042 Angular grid filters display streamlining
Moves all grid filter inputs and actions into a dropdown menu accessed
by clicking on the 'Filter' text-and-icon along the top of each grid
column (when filters are enabled).  Moving the actions into the
drop-down means the filter inputs, etc. are only visible when accessed
and have minimal impact on the primary grid display.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
d8666c06d389...
Jane Sandberg
LP1889128 (follow-up) associating inputs and labels
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
d5e6c2969aba...
Bill Erickson
LP1896285 Batch mark item missing serialized
Process batches of items one at a time when marking them lost to avoid
sending too many parallel requests to the server.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
d1793941b994...
Bill Erickson
LP1846042 Angular grid filter dropdown improvements
Add an explicit Close button to filter dropdowns to cover cases where
the user wishes to close the dropdown without making any changes and
clicking-away is not supported.

Othor minor repairs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
d0a04a6859cb...
Dan Briem
LP#1778522 Precat item creation should be more intentional
Precat items can be created before all of the info is entered.
The dialog autofocuses the title field, so a double barcode scan
will populate the title field and createt the precat without
giving an opportunity to fill in the other fields.

This prevents form submission unless you click the Precat
Checkout button.

To test:
1. Try to check out a barcode that doesn't exist to any patron
2. On the precat dialog, enter a value into the title field
3. Note the precat is created
4. Apply patch
5. Repeat steps 1-3 and note the precat isn't created until
  the Precat Checkout button is clicked

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
c81dd695ebeb...
Bill Erickson
LP1896285 Add new items avoids looping settings lookup
Refactor AngJS volcopy item add actions so it makes the minumum
necessary settings API calls for default copy status.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
c6061319a9cf...
Galen Charlton
LP#1855457: make grid headers in Angular admin interfaces sticky
Grid headers in Angular admininstration interfaces that use
subclass, or copy from AdminPageComponent are now sticky.

To test
-------
[1] Apply the patch and examine Angular admin pages that are
    are based on AdminPageComponent. A good example is the
    MARC Search/Facet Fields server admin page.
[2] Make the grid display a large number of rows, then scroll
    the page. Verify that the grid header is sticky (i.e.,
    the header remains visible in the viewport).
[3] Verify that the Carousels and Standing Penalties local admin
    grids have stick headers.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
c491e97a9544...
Jason Boyer
Correct asciidoc issues
The values for col need to be quoted and the [#..] anchor style
needs to be used in this fashion: [#..]#some phrase# while a simple
anchor is just [[..]].

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
ad6ccd96f63e...
Bill Erickson
LP1911031 Staff catalog honors pickup lib change
Manually modifying the pickup library in the staff catalog holds
placement form now results in using the selected pickup library.
Previously, the change was ignored by the form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
aca6cae69f77...
Chris Sharp
LP#1398107: Alert when autodeleting a title with holds on it.
Add a new "TITLE_HAS_HOLDS" event that we pass up to the user
if any non-canceled, unfulfilled title hold targets a bib that
would otherwise be silently deleted with holds canceled.

Also, retarget any holds pointing to a bib that is automatically
deleted after removing its volumes/copies to the destination bib
if this is the last copy.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
a76b27993e21...
Chris Sharp
Forward-port 3.4.4-3.4.5 version upgrade script
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
a5941cbbf852...
Bill Erickson
LP1889128 Holds reset repairs and making space
Collapse the Search Form on the holds page so the holds form and data
have more vertical room on the page.  Additionally, to help alleviate
any confusion that may be caused by the collapsed search form (and
because it has come up in other conversations), add a 'Return' button to
the holds page so users have an obvious way back to the previous catalog
page.

Fixes an issue where setting the hold recipient from a patron to the
staff account failed to properly clear the holds form, leaving (e.g.)
the wrong pickup lib in the selector.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
a19015827108...
Jane Sandberg
Docs: release notes for 3.5.2
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
9ff0d6f54450...
Bill Erickson
LP1889128 Activation date repair and form reset handling
Fixes an issue where the holds activation date was not correctly
retrieved from the form.  Related, hold suspension and activation date
values are now reset/cleared when a new hold receipt is selected.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
9c1b15d32708...
Bill Erickson
LP1889128 Clear patron barcode on staff hold
Clear the patron barcode from the barcode input when toggling the holds
placement form to request a hold for the logged in staff account.
Otherwise, the barcode sticks around and could cause confusion.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
9b683dd3d328...
Bill Erickson
LP1889128 Support user settings for SMS prefs
Honor the user setting values 'opac.default_sms_carrier' and
'opac.default_sms_notify' in the Angular staff catalog place holds form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
770689d69c72...
Galen Charlton
LP#1846042: turn on grid filtering for Angular admin pages
This WIP patch enables grid filters for Angular administration
pages.

TODO:

1. Enable for pages that override or do not use the default
  AdminPageComponent
2. Reconcile with the gridFilter URL parameter that booking
  (e.g.) uses.
3. Reconcile the top-level org unit filter widget with
  grid column org unit filters.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
75b33954554d...
Jeff Davis
LP#1896285: progress dialog when marking selected items as missing
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5664df8482b2...
Bill Erickson
LP1887429 Holds supports circ.staff_placed_holds_fallback_to_ws_ou
Add support for the 'circ.staff_placed_holds_fallback_to_ws_ou' org unit
setting when staff place holds for patrons in the Angular staff catalog.
Specifically, if the patron has no preferred pickup lib set, fall back
to either the patron's home org or the workstation org depending on the
value of the org setting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
46603396a83c...
Dan Briem
LP#1887852 Pending patron passwords aren't initially set to phone #
If a patron self registers with a phone # and the org unit
setting to use the phone for the password is true, when the
pending patron stage loads the password is initially random
instead of the last 4 digits of the phone #.

This branch sets the password to the last 4 digits of the phone
when the patron stage loads if the phone is set and the org
unit setting to use the phone # for the password is true.

To test:
1. Set org unit settings for allow patron self-registration and
  show day_phone on registration to true
2. Go to the OPAC and request a library card (include phone #)
3. Login to the staff client, Circulation->Pending Patrons and
  load the patron
4. Note the password is random
5. Load patch and repeat steps 3-4
6. Note the password is the last 4 digits of the phone #

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jason Stephenson <jason@sigio.com>
457d75b79ba5...
Jane Sandberg
Docs: fix typo in 3.6 release notes
Thanks to Elizabeth Thomsen for catching this error.
43b51646b52c...
Bill Erickson
LP1889128 Staffcat support placing multiple holds
Adds support for the org unit setting 'circ.holds.max_duplicate_holds',
which allows staff to place multiple holds per target in the staff
catalog hold placement UI.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3ca0579b4055...
Bill Erickson
LP1889128 Reset hold recipient info after success
* When all holds for a given recipient have been successfully placed,
directly or via override, clear the recipient data so new recipient data
can easily be added.

* When placing duplicate Part holds, ensure the same part is applied to
each hold context so the selected part is targeted for all of the
multi-holds.

* Fxes a regression in the display of multiple hold targets where only
the first target would display.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
39a2dee1f2ee...
Bill Erickson
LP1889128 Staffcat holds recipient / multi-hold repairs
1. Modifying the patron barcode input either directly or via patron
search now fully resets the form, including previously placed holds.

2. Modifying the hold receipient clears the previous "placing hold for
patron" receipient applied from within the patron app, i.e. the banner
along the top of the catalog page.

3. Hide the 'Number of copies' selector when multi-copy holds are not
supported.

4. Hide the 'Number of copies' selector when the request does not have
CREATE_DUPLICATE_HOLDS permissions for the currently selected

5. Display an error message when the barcode entered does not result in
finding a patron.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3996fa89906a...
Bill Erickson
LP1887429 Properly handle user settings in staffcat holds
Treat user settings like the raw JSON values that they are
when fetched via fleshing.  Also be sure the value for the
'opac.default_pickup_location' user setting is read as a number in the
staff catalog to ensure it can be linked to the org unit in question.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
33f9590d59e6...
Galen Charlton
LP#1846042: take advantage of ngbDropdown container="body"
This feature, which is available as of ng-bootstrap 4.1.0,
allows the grid filter control columns to stay alligned with
the column label and data on small viewports and/or tables
with lots of columns.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
1afbf5aba860...
Bill Erickson
LP1889128 Confirm data loaded before Place Hold activated
When changing users in the place hold form of the staff catalog, the
form resets itself and refreshes all of the user and bib, etc. data.
This patch ensures all data has been retrieved before the place hold
button is reactivated after changing the user.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
1ad04e4036b0...
Garry Collum
lp1903424 Bootstrap opac notification methods not saving
The hold and email hold notification methods in the Bootstrap opac do not save to the database.
This patch fixes that behavior.

To test in concerto.
1. Enter an email address into a patron record.
2. Place a hold in the Bootstrap Opac logged in as this patron.
3. For notification, select Yes for email, and Yes by phone. Enter a phone number.
4. Go to the staff interface and observe that the hold for this patron does not have the Notifications Phone set, and Notify by Email is No.
5. Apply the patch.
6. Place another hold for this patron using the same notification settings.  The Notifications Phone is now set, and Notify by Email is yes.
7. Use a combination of notification settings for other holds to verify that setting a phone or email notification method is set or not depending on what is selected.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
1019f5c76709...
Bill Erickson
LP1889128 Staffcat hold form reset option
Adds a Reset button to the staff catalog holds form so subsequent holds
may be placed for the same items but for different patrons.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
0f457e4d8ec8...
Chris Sharp
LP#1398107: Add header to generic alerts.
Currently, generic alerts/events passed up from the Perl
layer are presented in an unadorned modal that just begins
with "Reason(s) include" without further context.  This
adds a "Could not Complete the Action" header with the
idea that something is better than nothing.  At this point,
i18n is not considered.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
0b26b7f64c14...
Chris Sharp
LP#1398107: Add i18n attribute to alert text
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
0a7eef2a73dd...
Bill Erickson
LP1896285 Post mark-missing serialized item load
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
044b4de34589...
Bill Erickson
LP1889128 <eg-date-select/> clearable via model
Allow users of <eg-date-select /> to clear the selected value (set
current = null) via updates to their ngModel variable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
0297d91ccfb3...
Jason Boyer
Forward-port 3.6.1 upgrade script
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
0103dc1e0794...
Jane Sandberg
Docs: release notes for 3.4.5
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>