Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

fb6d28835bb9...
Jason Stephenson
Lp 1899974: Export PERL5LIB in oils_ctl.sh
A change in Perl release 5.26.0 necessitates that the SIP_DIR variable
(default value "/opt/SIPServer") be exported to the environment in
oils_ctl.sh when attempting to start SIPServer.  This change affects
Ubuntu 18.04 (Bionic Beaver) and Debian 10 (Buster) and any future
releases.

To verify the bug:

1. Install OpenSRF, Evergreen, and SIPServer on an affected O/S.
2. Start OpenSRF service.
3. Start SIPServer via oils_ctl.sh:
  oils_ctl.sh -a start_sip
4. Notice the "Starting OILS SIP Server" message is printed with no
  indication of failure.
5. Verify that the PID file exists: /openils/var/run/oils_sip.pid
6. Verify that no SIPServer processes are actually running:
  pgrep -af SIPServer
  The above should produce no output.

To test this patch:

1. Apply this patch and install oils_ctl.sh to /openils/bin/.
2. Assuming you have run the previous steps, delete the PID file:
  rm /openils/var/run/oils_sip.pid
3. Start SIPServer via oils_ctl.sh:
  oils_ctl.sh -a start_sip
4. Notice the "Starting OILS SIP Server" message is printed.
5. Verify that the PID file exists: /openils/var/run/oils_sip.pid
6. `pgrep -af SIPServer` should produce output.

It is safe to apply this patch on an unaffected O/S.  Explicitly
adding SIP_DIR to PERL5LIB will have no detrimental effect on any O/S
currently supported by Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
f685c2a69c95...
Chris Sharp
LP1919465: stamp upgrade script
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
e6097bf5baa9...
Jason Stephenson
LP1940146: Debian Bullseye Installation Support
Update documentation and prerequisite installation Makefiles to add
support for Debian Bullseye (11.0).

Use PKG_CHECK_MODULES instead of AC_CHECK_PROG to test for the
presence of yaz.  This is done because of the following Changelog
entry:

    yaz-config and its man page are no longer packaged.  Please switch
    to pkg-config (yaz, yaz-icu or yaz-server).  This also makes the
    package reproducible.  Closes: #955501

This change works on all currently supported Evergreen distros.  You
can test it by running autoreconf -f and then running the normal
configure command.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
e5164b98987f...
Bill Erickson
LP1919465 Avoid dupe Current Item's in pull list
* Show a value for Current Item when a hold is targeted
* Show a value for a new column on Requested Item for copy-level holds.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
e3245f34776b...
Chris Sharp
Revert "Docs: added receipt contents references."
This reverts commit 649d81b06ecee12324d3a4c604ea20451c3fea85.
d84c5c723633...
Terran McCanna
LP1881012 Typo in staff/circ/hold/app.js
Fixes 'legnth' typo.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
d80b607d6819...
Galen Charlton
LP#1944765: enable the Apache module mod_headers
This patch enables mod_headers for Debian Stretch and Buster
and Ubuntu Bionic and Focal during installation. Without
mod_headers, the Angular staff client application can have
its index page cached for 24 hours on a stock system, meaning
that browsers will not consistently fetch the updated app
after an upgrade.

This patch does not change the Fedora Makefile as mod_headers
is enabled by default on RHEL-like distributions.

UPGRADE NOTES
-------------
Existing Evergreen systems on Debian and Ubuntu should
do the following to ensure that mod_headers is active:

sudo a2enmod headers
sudo systemctl restart apache2

To test
-------
[1] Perform a fresh installation of Evergreen on Stretch, Buster,
    Bionic, or Focal.
[2] Verify that mod_headers is enabled.
[3] (Optional) Fetch the Angular staff client index page, e.g.,
    /eg2/staff, and verify that the response headers call for
    not caching it.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
cf9eeea7816c...
Bill Erickson
LP1919465 Fix default holds pull list sorting
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
ce371f45408d...
Bill Erickson
LP1919465 Pull list prefix/suffix sorting; columns
* Include call number prefix and suffix in hold pull list sorting.
* Apply sane default grid columns.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
cbed258094a8...
Jason Boyer
LP1850156: Remove Browsers From *-developer Targets
Because the developer targets are currently necessary for a from-git
installation, both Firefox and Chrome are removed and the docs updated
to note that you should install one or both if you want to run the tests.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
c8f1fb223a1f...
Bill Erickson
LP1919465 Pull list detail show record summary
Display the bib record summary when displaying the hold detail view from
the holds pull list.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
c5db166b7e88...
Jason Stephenson
Lp 1826759: Fix Database Upgrade Script
Remove 2 extraneous updates, add a blank line between the remaining
updates, and add a placeholder the upgrade_deps_block_check().

Signed-off-by: Jason Stephenson <jason@sigio.com>
bec57122105a...
Jason Boyer
LP1928258: Correct Upgrade Script
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
bb8723d55ac8...
Jason Boyer
Remove XUL opensrf.math Client
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
994a429f6a4c...
Bill Erickson
LP1919465 Relabel Item Location -> Shelving Location
Rename various "Item Location ..." references to "Shelving Location ..."
in the Angular holds grids.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
99199a9548bc...
Jason Stephenson
Lp 1942920: Show Legacy/Not Dated for Legacy Circs
When legacy circ counts are displayed in the AngularJS client, the
year shows up as -1.  This patch attempts to replace -1 with a
translatable string: "Legacy/Not Dated" as was used in the XUL staff
client.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
97bf745e8dbb...
Chris Sharp
LP#1944765: add headers to bullseye install script
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
90547d644f95...
Galen Charlton
LP#1919465: fix issue with DB rev stamping
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8d61829a5d43...
Bill Erickson
LP1919465 Pull List Mark Discard/Weed Action
Includes general purpose discard/weed dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
85f483d06176...
Jason Boyer
LP1940146: Debian Bullseye Installation Support
This commit also addresses LP 1940145: Remove Installation
Support for Debian Jessie. The individual distribution-specific
targets (stretch, buster, etc.) have also been removed since
they are now all the same, much like both Ubuntu targets just
call ubuntu_generic. The two generic targets have been left
in case they're necessary again in future.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7c97b79cf36e...
Jason Boyer
LP1940146: Update documentation
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
70c18bae2601...
Bill Erickson
LP1919465 Pull list only shows holds with current_copy
This avoids a scenario where copy-level holds would appear in the pull
list even if they are not pull-able, because they have "a copy" (i.e.
the requested copy), but no current copy (i.e. targeted copy).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
70c07897f032...
Galen Charlton
LP#1928258: update pgTAP regression test
Now that update_bib_editor is split out into a separate
merge profile field, need to account for that in the regression
test for 1447746.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
705029f00030...
Jason Stephenson
Lp 1826759: Stamping Upgrade Script
Signed-off-by: Jason Stephenson <jason@sigio.com>
7046a55443df...
Galen Charlton
LP#1928275: fix the Angular "Copy Queue To Bucket"
Similar to bug 1934184, a blank routerLink on an anchor no longer
causes an ngbModal to open via a click handler.

To test
-------
[1] Create a MARC import bib queue that has at least one imported
    record it.
[2] Click the "Copy Queue To Bucket" link from the queue inspection page
    and observe that nothing happens.
[3] Apply the patch and repeat step 2. This time, the add-to-bucket dialog
    should appear.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
6aecb1ab4228...
Mike Rylander
LP#1901597: Allow multi-subfield match in vandelay.strip_field
Now, when supplying a subfield match restriction for use with
vandelay.strip_field, you can separate multiple restrictions with '&&'
(no quotes).  For instance, to remove a Located URI 856 for for a
combination of a specific owner and a specific domain, you might say:

856[u~oldservice.com && 9~MYLIB]

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6114ea381180...
Shula Link
LP1834258 Replace Javascript with Placeholder Attribute
onfocus/onblur javascript replaced with placeholder="[% seed %]" in
Open-ILS/src/templates/kpac/getit.tt2 and
Open-ILS/src/templates/kpac/parts/searchbox.tt2

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5672931d9cd0...
Tiffany Little
LP1848575 Angular boolean filters should use Yes/No
Changes the filter options for boolean values to Yes/No instead of True/False.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
48686a9f01e0...
Galen Charlton
LP#1864516: (follow-up) install current version of function
Fixes a regression that caused bib record saves to fail

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
439b75deada6...
Chris Sharp
LP#1901597: Stamp upgrade scripts
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
38870040ac68...
Bill Erickson
LP1938729 Cache "cascade" setting values
Cache values retrieved from 'open-ils.actor.settings.retrieve' lookups
in IndexedDB, similar to to org unit setting lookups, to reduce the need
for so many API calls for settings retrieval.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
30200672a832...
Garry Collum
LP1924621 Staff catalog place hold screen preferred name
Displays the preferred first or last name on the place holds screen,
if a patron barcode is entered.

To test.
1. Set up a borrower with a preferred first name, and one with a
preferred last name, and one with both.
2. Use the catalog place hold screen to search for these borrowers
and notice that the preferred names, if available, are displayed.

* note newline added by Bill to break up wide column.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
276e0d2cf844...
Jason Stephenson
LP1940146: Clarify README
Clarify Ejabberd shaper settings instructions for Debian 11, Bullseye
in the README.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
26e587b6eb55...
Bill Erickson
LP1919465 Holds pull list Angular / Wide Holds API Port
Ports the holds pull list to Angular and takes advantage of the new Wide
Holds API.  Includes seed data for grid preferences and a new holds pull
list (server) print template.

The UI displays the total holds count and includes a org unit selector.
It pre-fetches all holds, partly to display the full count, but also
based on the assumption that a pull list will typically be used all or
none.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
22a117ded711...
Bill Erickson
LP1924621 Place Hold For shows pref name
In the staff catalog banner which displays when a hold is being placed
for a pre-selected patron.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
17925e75d743...
Josh Stompro
LP#1924562 - pingest.pl help typo for --max-duration
In the help command example the argument --duration is used but
--max-duration is the correct command.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
1128b7648e29...
Shula Link
Lp 1826759: Spelling correction: oustanding to outstanding
Correct the spelling of "oustanding" to "outstanding" in the
descriptions of 3 config.org_unit_setting_type entries:

  * ui.circ.items_out.longoverdue
  * ui.circ.items_out.lost
  * ui.circ.items_out.claimsreturned

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
0fb9e371c812...
Terran McCanna
LP1909144 BooPAC Login Form Tabbing
This change places the cursor in the user name field and adjusts the order
of the elements so that tabbing out of the user name field comes to the
password field next.

Note that this modifies both the login modal and the embedded login form.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
0ebe44731482...
Jason Stephenson
Lp1940145: Remove Installation Support for Debian Jessie
Remove references to Debian Jessie (8.0) in the installation and
upgrade documentation as well as from the prerequisite installation
Makefiles.  Debian 8 has been out of long term support for over a year
at this point.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
071e1b545578...
Bill Erickson
LP1911023 Batch hold cancel refreshes before completion
Ensure all hold cancelation promises complete before reporting the
results back to the caller.  Issue was result of thinko in the code
that failed to relay one of the promises in the chain, so it reported
promise completion prematurely.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>