Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Failed Again Running Exception Offline No data

fff3d40e087b...
Ben Shum
i18n: fix es-ES webstaff translation
Repairs a number of variables, spacing, and function names that were
mistranslated in the Spanish webstaff file.

Signed-off-by: Ben Shum <ben@evergreener.net>
  • evergreen-master-fedora-18: pylint failed -  stdio
ea0569d7c23f...
Mike Rylander
LP#1746584: Adjust bib visibility test for patron browse
With updates to address visibility testing issues for LURIs, a change was made
to allow the default bib tests to supply the most appropriate query_int
operator with which to join those to non-default tests.  The browse code,
however, is all database-level and was not adjusted with the Perl code that
implements general search.  This commit addresses that issue by acknowledging
that the bib vis testing code to provide its own operator, either | or &, as
appropriate to the actual default test values.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
e70d5917f50e...
Jason Stephenson
LP 1694058: Add org. unit setting for multiple hold placement.
Add config.org_unit_setting_type circ.hold.max_duplicate_holds to set
the maximum duplicate title or metarecord holds allowed per patron.

Add pgtap test to make sure the new setting exists.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
d44bf3c9a6e4...
Jane Sandberg
Release notes for 2.12.10
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
cb2486340409...
Bill Erickson
LP#1739803 Add newly required dependency for jasmine-core
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
cac2694533ba...
Jason Stephenson
LP 1694058: Add confirmation dialog for multiple title holds.
Add a dialog to confirm that the user really wants to place the
requested number of title or metarecord holds to the
validateHoldForm() function.

Along the way, we add a format() function to the JS String prototype
in the i18n_strings.tt2 so that we can have translated strings with
placeholders in JavaScript.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
b90b6eaca8ac...
Bill Erickson
LP#1745499 Patron bucket from file query consolidation
Replace one-pcrud-call-per-barcode with a single (streaming) pcrud
search call to fetch patron cards when using the barcode file upload
option in the web staff pending patron bucket UI.  This avoids spawning
high number of pcrud processes.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
ad87d0b11ac1...
Jason Stephenson
Lp 1749593: Fix TypeError: Cannot set property 'grid' of undefined
Commit b35f0c0 added a reference to the grid in the grid.dataProvider
in services/grid.js in the web staff client.  This is great, but the
dataProvider could be undefined where it was being set.  This leads to
busted grid views and a TypeError in the console.

This commit moves the code down until after a fallback dataProvider is
used when the dataProvider is undefined and thereby avoids both
problems of adding the grid to an undefined dataProvider.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
a63bae0c57e8...
Bill Erickson
LP#1739803 Angular 1.6 + dependency updates
Rebuild package.json starting with Angular 1.6.  This resulted in a
number of dependency updates and small changes required to keep the
dependencies happy.

* Teach print.js to use promise-style $http responses, instead of
  .success() and .error()
* Remove unused '$http' dependency in hatch.js
* Fix egDate custom test matcher to work with newer version of
  karma-jasmine.
* Build IDL for test scripts using Grunt/exec "cwd" since Grunt fails to
  understand "&&" commands, like 'cd foo && bar'.
* For correctness, move dev-only depenencies into the package.json
  devDependencies section.

See also
https://docs.angularjs.org/guide/migration#migrating-from-1-5-to-1-6

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
a61f5bb7dc76...
Jason Stephenson
LP 1694058: Perl tests for backend multiple hold placement changes.
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
986a2d011726...
Kathy Lussier
LP#1694058: Stamping upgrade script for duplicate holds coust
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
8cbcdf69b2a4...
Jane Sandberg
Adding 3.0.4 release notes
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
89eb96b8eaae...
Jason Stephenson
LP 1694058: OPAC changes for multiple title and metarecord holds.
We add the num_copies select box to the place_holds.tt2 whe appropriate.

The new select list generator has its own tt2 file:
Open-ILS/src/templates/opac/parts/multi_hold_select.tt2

Modify WWW/EGCatLoader/Account.pm to properly process multiple hold
requests for the same title or metarecord.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
7e76706a0b34...
Jason Stephenson
LP 1694058: Final OPAC Changes for Multiple Hold Placement
Add JavaScript code to disable the number of copies selection when a
part is chosen for a record that has both parts and non parts holds
available.  If a part is chosen, the number of copies select should be
disabled and reset to 1.  It should be enabled again if the All Parts
option is chosen.  It does not appear if the hold requires a part.

Test Plan for the OPAC changes:

1. Set circ.holds.max_duplicate_holds to 5 for BR1.

2. Login to the OPAC as any patron from BR1.

3. Perform any search.

4. Select a title and click Place Hold.

5. See that the selection box for placing multiple holds does not appear on the place holds screen.

6. Place the hold to see that hold placement still works as expected.

8. Go to the patron’s list of holds in My Opac to see that the hold appears.

9. Cancel the hold so it doesn’t interfere with later testing.

10. Logout.

11. Login to the OPAC as any patron from BR2 or any branch other than BR1.

12. Perform any search.

13. Select a title and click Place Hold.

14. See that the selection box for placing multiple holds does not appear on the place holds screen.

15. Place the hold to see that hold placement still works as expected.

16. Go to the patron’s list of holds in My Opac to see that the hold appears.

17. Cancel the hold so it doesn’t interfere with later testing.

18. Logout.

19. Login to the web staff client as a circulator for BR1 at BR1.

20. Select a patron barcode for any BR1 patron.

21. Perform any search.

22. Choose a title without parts and click place holds.

23. See that the selection box for placing multiple holds appears with 1 as the default.

24. Click the selection box to see that the values go from 1 to 5.

25. Place any number of holds for the patron whose barcode was chosen in step 15.

26. Open the patron in the staff client and check the patron’s holds list to see that they have the correct number of holds for this title listed.

27. Repeat steps 21 – 26 with metarecord holds on one of the metarecord titles.

28. Perform a search and select a title.

29. Choose an item to place a copy hold for the same patron.

30. Notice that the multiple hold number selection box does not appear.

31. Place the hold as normal (if you like) to test that copy hold placement still works.

32. Search for a title with parts.

33. Select a part in the parts drop down or radio button.

34. Notice that the number of copies select box is reset to 1 and disabled when a part is selected.

35. Repeat the above steps for a BR2 circulation account logged in at BR2 (or any other branch staff).

36. Notice that the selection box never appears when placing holds where the org. unit setting does not apply.

37. Clear the org. unit setting for BR1 and repeat the above steps, if desired.

The web staff client tests should work in the XUL staff client as well.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
76f56e0f027f...
Bill Erickson
LP#1739803 Quiet some repetitive console messages for unit tests
These console logs repeat during unit test runs and add clutter (ditto
the browser console log).  I commented them out instead of removing them
since they may still be useful for debugging in the future.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
760140b2b5fe...
Dan Wells
LP#1749992 Disable payment button during payment
Since the display is not refreshed until the payment finishes, it
is possible to fire off a second payment by double-clicking.

This commit is a simple way to disable the button while a payment is
in process, then enable it again after the display refreshes.

Since the 'sendPayment()' function is wrapped, we may need to move
this logic up, but this being a single promise is simpler, and it
solved the problem in testing.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
6dbb6c76aa52...
Kathy Lussier
LP# 1694058: Release notes entry for placing multiple holds
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
664608a1b056...
Jane Sandberg
Docs: fixing typo in 2.12.9 release notes
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
5eadd3febbe0...
Bill Erickson
LP#1739803 Remove superseded 'extern' directory
angular-location-update.js is now managed via npm.  No need to retain a
copy in the repo.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
5c6e280e147b...
Bill Erickson
LP#1739803 Webstaff: Replace Grunt with Webpack
* Remove grunt devDependencies
* Add Webpack devDepenencies
* Copy and minify operations are now handled by Webpack via 'npm run
  build' for dev builds and 'npm run build-prod' for
  production/minified builds.
* Running 'npm run build-watch' executes webpack in --watch mode to
  watch for affected file changes and automatically rebuild.  Useful for
  development.
* Karma unit tests are now invoked directly from node via 'npm run
  test'.
* Docs and release installer updated to match.
* Removed long-outdated inline installer readme.

Webpack is configured to create bundles from sets of JS files.  As it
stands, there are 2 sets: core.bundle.js and vendor.bundle.js.  Core has
all of the EG core services that are loaded on every page.  Vendor
contains all of the 3rd-party dependencies (angular, etc.).  These 2
bundles are loaded on every web staff page (via base_js.tt2).

All other <script/> tags remain as they were.

When building in dev mode ('npm run build'), core service JS files are
bunded un-minified with an inline source map for debugging.  Vendor
files (angularjs, etc.) are always minified because they are quite
large.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
32b0358678f4...
Jason Stephenson
Lp 1746584: Stamping Upgrade Script
Signed-off-by: Jason Stephenson <jason@sigio.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
143879125062...
Jason Stephenson
LP 1694058: Add backend code to allow multiple hold placement.
We add a constant for the circ.holds.max_duplicate_holds setting.

We modify Holds.pm to check if we're placing a title or metarecord
hold, that we have the CREATE_DUPLICATE_HOLDS permission, and that we
haven't placed more than the maximum allowed number of duplicate holds
before returning the HOLD_EXISTS event.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
0a81e0d2bf2b...
Galen Charlton
LP#1739803: add angular tablesport to vendor bundle
Otherwise, offline breaks.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
04bf77f7feac...
Jason Stephenson
Lp 1694058: Fix Issue With Place Holds Reported in Testing
When staff did have to override in order to place the hold, and the
"Place another hold for this title" link was subsequnetly used, the
inputs for the patron barcodes and some other fields on the place
holds page were duplicated.  To avoid this, we now use uniq from the
List::MoreUtils library when retrieving the hold targets list from the
CGI parameters.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
044c42dd1dee...
Bill Erickson
LP#1745499 De-Parallelify Item Status file upload
Fetch copies in a series instead of in parallel when loading copy
barcodes from a file in the Item Status interface.  This helps avoid
excessive pcrud process count.

Since this causes the action to take a little longer, the commit also
includes a progress dialog indicating copy retrieve progress.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
  • evergreen-master-fedora-18: pylint failed -  stdio