Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Change #8480

Category None
Changed by Galen Charlton <gmcohnoyoudont@equinoxOLI.org>
Changed at Tue 31 May 2022 10:26:02
Repository git://git.evergreen-ils.org/OpenSRF.git
Project OpenSRF
Branch master
Revision 9fa5fbbd05d2ade6a6359c16ff6056561fbeca51

Comments

LP#1974193: fix memory leak in C apps
This patch fixes a memory leak that can occur when
a C app does the following:

- send a non-chunked response
- add a response to a bundle to send later
- send a request complete status message

The leak could add up for long-lived C apps.

To test
-------
[1] Set a up C app such as Evergreen's open-ils.pcrud and
    send a lot of requests to it whose responses would not be
    large enough to be chunked, but not so many as to go over
    max_requests. It may be helpful to limit the service to
    just a single child.
[2] Check memory usage of the child after the requests are
    processed.
[3] Apply the patch and repeat step 1. This time, memory
    usage should be less.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Changed files