Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Change #7473

Category None
Changed by Dan Briem <dbriemohnoyoudont@wlsmail.org>
Changed at Mon 09 Nov 2020 13:40:09
Repository git://git.evergreen-ils.org/Evergreen.git
Project Evergreen
Branch master
Revision 4d50691b51047128d8dafdcd5c0f06d8223d0532

Comments

LP#1900184 Patron password use phone not working
An early return statement in extract_hold_notify() was removed
in 7e92293 and added back in ddf5b4b3, so props set at the end
of that function used in future comparisons never get set.

This re-removes the return statement and sets the local notify
variable to default string values so the rest of the function
can play out.

To test:
1. Set org unit setting: "Patron: password from phone #" to TRUE
   at the top context location
2. Circulation->Register Patron
3. Type 123-456-7890 into the Daytime Phone field and press tab
4. Note: the password field isn't updated to the last 4 digits
5. Apply patch and repeat steps
6. Note: the password field updates to the last 4 digits

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>

Changed files