Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Change #6710

Category None
Changed by Dan Wells <dbw2ohnoyoudont@calvin.edu>
Changed at Fri 25 Oct 2019 10:25:27
Repository git://git.evergreen-ils.org/Evergreen.git
Project Evergreen
Branch master
Revision 07b8435ef57256ac42593799f2e796d0fec3d413

Comments

LP#1846038 Remove extra grid refresh from configuration load
Bug LP#1790169 added the ability to save sorting configuration, but it
also added an additional grid refresh to the configuration load.  This
breaks grid loading.

The expected flow is for is to first load any existing configuration,
then do the first collect() for the grid.  This refresh() call adds
potentially a second collect() which may run earlier than it should,
and overall does not seem necessary.

To test:

(Make sure you are testing on current master or rel_3_3/3_4, or you
will (like me) hit related bugs which have been fixed.  Also, some
grids (especially circ) do not honor sort for other reasons, so avoid
those for now.)

1) Find a grid which has a typical get() process.  Suggestion would be
a basic auto grid, such as full bill details,
https://localhost/eg/staff/circ/patron/11/bill/43/details .
2) Set a sort value you can see, then *save* the configuration.
3) Before the patch, billing details grid doesn't load.  After patch,
grid loads and still honors the defined sort.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Changed files