Builder osrf-master-debian-6.00-x86_64 Build #91

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

scheduler

Steps and Logfiles:

1. git update ( 6 secs )
   1. stdio
2. Bootstrap via autogen './autogen.sh' skipped ( 0 secs )
   1. - no logs -
3. Bootstrap via autoreconf 'autoreconf -i' ( 9 secs )
   1. stdio
4. configure configure ( 18 secs )
   1. stdio
5. compile compile ( 3 secs )
   1. stdio
6. test test 141 tests 141 passed ( 5 secs )
   1. stdio
7. trial 14 tests passed ( 1 secs )
   1. stdio
   2. test.log
   3. problems
8. pylint pylint convention=254 error=28 fatal=7 refactor=279 warning=87 failed ( 5 secs )
   1. stdio
   2. convention
   3. error
   4. fatal
   5. refactor
   6. warning

Build Properties:

Forced Build Properties:

Responsible Users:

1. Galen Charlton

   gmcohnoyoudont@equinoxinitiative.org
2. John Merriam

   jmerriamohnoyoudont@biblio.org

Timing:

All Changes:

:

1. Change #6268

   Category	None
   Changed by	John Merriam <jmerriamohnoyoudont@biblio.org>
   Changed at	Fri 07 Jun 2019 11:11:13
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	9a90f826e18b42ce6f508064c3ad68cf6d6c7c0a

   Comments

   LP#1824181: Allow 1st arg to logger to be string or subroutine
   This simple change allows the $msg passed to _log_message in Logger.pm
   to be either a regular string or a delayed exec subroutine. This is in
   reaction to LP1823338 where a slow debug logging statement was slowing
   down SIP checkins even though debug logging was not turned on.
   
   With this change you can take this:
   
   $log->debug("Available methods\n\t".join("\n\t", keys %{ $_METHODS[$proto] }), INTERNAL);
   
   and change it to this:
   
   $log->debug(sub{return "Available methods\n\t".join("\n\t", keys %{ $_METHODS[$proto] }) }, INTERNAL);
   
   and then that slow debug logging line will not be executed unless
   debug logging is turned on.
   
   Signed-off-by: John Merriam <jmerriam@biblio.org>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/perl/lib/OpenSRF/Utils/Logger.pm

2. Change #6269

   Category	None
   Changed by	Galen Charlton <gmcohnoyoudont@equinoxinitiative.org>
   Changed at	Fri 07 Jun 2019 11:31:59
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	703809d19a3336ee975d39efc3372363f6268365

   Comments

   LP#1824181: add test cases
   To test
   -------
   [1] Verify that 'make check' (or prove src/perl/t/09-Utils-Logger.t)
       passes.
   
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/perl/t/09-Utils-Logger.t

3. Change #6270

   Category	None
   Changed by	John Merriam <jmerriamohnoyoudont@biblio.org>
   Changed at	Fri 07 Jun 2019 11:31:59
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	32c6058def9336eaf4f36da2930a147240392e9d

   Comments

   LP#1824184: Change potentially slow log statements to subroutines
   The OpenSRF code was searched for potentially slow logging statements at
   log level info or above. We then changed those logging statements to be
   delayed execution subroutines. This is in reaction to LP1823338 where a
   slow debug logging statement was slowing down SIP checkins even though
   debug logging was not turned on.
   
   Here is some pseudocode that shows what is being done here:
   
   $log->debug("Some text " . $some->slow_method);
   
   would be changed to:
   
   $log->debug(sub{return "Some text " . $some->slow_method });
   
   With this change, an unnamed sub is passed to the OpenSRF logger module
   and it will not be executed unless the global logging level is set to
   debug or higher (the slow_method will not be called unless it is needed
   for that logging level).
   
   ********
   If/when this is committed, please use delayed execution subroutines for
   any logging statements that could be slow in the future. It is recommend
   that any logging statements that do not consist entirely of quoted text
   and/or already available scalar variables use delayed execution
   subroutines.
   ********
   
   Testing notes
   -------------
   [1] This patch reduced the duration of open-ils.storage.actor.user.total_owed
       calls on a test system from an average of 0.13 seconds to an overage
       of 0.009 seconds.
   [2] It didn't materially affect the duration of calls to
       open-ils.actor.user.opac.vital_stats.
   [3] This make sense: open-ils.storage has far more generated methods
       than open-ils.actor.
   [4] There are enough instances in Evergreen of using method_lookup to find
       routines in open-ils.storage that the speed improvement may well be
       perceptible to humans, not just SIP sorters.
   
   Signed-off-by: John Merriam <jmerriam@biblio.org>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/perl/lib/OpenSRF/AppSession.pm
   • src/perl/lib/OpenSRF/Application.pm
   • src/perl/lib/OpenSRF/DomainObject/oilsMessage.pm
   • src/perl/lib/OpenSRF/EX.pm
   • src/perl/lib/OpenSRF/MultiSession.pm
   • src/perl/lib/OpenSRF/Server.pm
   • src/perl/lib/OpenSRF/Transport.pm
   • src/perl/lib/OpenSRF/Transport/SlimJabber/Client.pm