Builder osrf-master-debian-6.00-x86_64 Build #77

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

scheduler

Steps and Logfiles:

1. git update ( 0 secs )
   1. stdio
2. Bootstrap via autogen './autogen.sh' skipped ( 0 secs )
   1. - no logs -
3. Bootstrap via autoreconf 'autoreconf -i' ( 6 secs )
   1. stdio
4. configure configure ( 12 secs )
   1. stdio
5. compile compile ( 10 secs )
   1. stdio
6. test test 138 tests 138 passed ( 4 secs )
   1. stdio
7. trial 14 tests passed ( 0 secs )
   1. stdio
   2. test.log
   3. problems
8. pylint pylint convention=254 error=28 fatal=7 refactor=279 warning=87 failed ( 5 secs )
   1. stdio
   2. convention
   3. error
   4. fatal
   5. refactor
   6. warning

Build Properties:

Forced Build Properties:

Responsible Users:

1. Chris Sharp

   csharpohnoyoudont@georgialibraries.org
2. Galen Charlton

   gmcohnoyoudont@equinoxinitiative.org
3. Jason Stephenson

   jasonohnoyoudont@sigio.com

Timing:

All Changes:

:

1. Change #5374

   Category	None
   Changed by	Chris Sharp <csharpohnoyoudont@georgialibraries.org>
   Changed at	Mon 07 May 2018 15:50:57
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	2e5c11c04c4db962aebf4b8632ce35a46434cd12

   Comments

   LP#1243841 - Wrap truth test using "=" in an extra set of parens.
   Referring to https://stackoverflow.com/questions/5476759/compiler-warning-suggest-parentheses-around-assignment-used-as-truth-value,
   it is recommended to wrap variable assignments that are used as a truth
   test within an extra set of parentheses.
   
   Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
   Signed-off-by: Jason Stephenson <jason@sigio.com>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/libopensrf/osrf_cache.c

2. Change #5375

   Category	None
   Changed by	Chris Sharp <csharpohnoyoudont@georgialibraries.org>
   Changed at	Mon 07 May 2018 15:53:42
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	6aedae0b42434c95f22924ed4b93ba726353f034

   Comments

   LP#1243841 - Quiet unused return value warnings.
   Using advice given here: https://stackoverflow.com/a/13999461, "The
   only good (if ugly) way to suppress these is to convert the return
   value into something that the compiler agrees that you can ignore."
   
   Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
   Signed-off-by: Jason Stephenson <jason@sigio.com>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/libopensrf/utils.c

3. Change #5376

   Category	None
   Changed by	Chris Sharp <csharpohnoyoudont@georgialibraries.org>
   Changed at	Mon 07 May 2018 15:54:56
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	f8f1813bf17f745719c9dabbdfc5c7bed05c7138

   Comments

   LP#1243841 - Quiet unused return value warning in srfsh.c
   Using the technique described here: https://stackoverflow.com/a/13999461.
   
   Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
   Signed-off-by: Jason Stephenson <jason@sigio.com>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/srfsh/srfsh.c

4. Change #5377

   Category	None
   Changed by	Chris Sharp <csharpohnoyoudont@georgialibraries.org>
   Changed at	Mon 07 May 2018 15:55:21
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	9dd65c72e5bd114eb1e1d6c2b1388e01df02bbb8

   Comments

   LP#1243841 - Quiet wrong format warnings during make install.
   During make install, the compiler warns that %d expects an int when the
   actual value is a long int.  Changing %d to %ld fixes the issue.
   
   Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
   Signed-off-by: Jason Stephenson <jason@sigio.com>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/gateway/osrf_websocket_translator.c

5. Change #5378

   Category	None
   Changed by	Jason Stephenson <jasonohnoyoudont@sigio.com>
   Changed at	Mon 07 May 2018 15:55:48
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	f47f108e7a2af04360c872313978be6ce71c5c25

   Comments

   LP#1243841 - Quiet additional Make warnings and some code cleanup.
   We make the following warnings go away:
   
   osrf_legacy_json.c:607:6: warning: variable ‘fourth_dash’ set but
   not used [-Wunused-but-set-variable]
   
   osrf_legacy_json.c:836:5: warning: passing argument 3 of ‘makeNode’
   discards ‘const’ qualifier from pointer target type [enabled by
   default]
   
   utils.c:133:2: warning: format not a string literal and no format
   arguments [-Wformat-security]
   
   We also cleanup the while block nested in a do while block around line
   63 of osrf_cache.c to be more readable by adding braces and breaking
   it across 3 lines.
   
   Signed-off-by: Jason Stephenson <jason@sigio.com>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/libopensrf/osrf_cache.c
   • src/libopensrf/osrf_legacy_json.c
   • src/libopensrf/utils.c

6. Change #5379

   Category	None
   Changed by	Jason Stephenson <jasonohnoyoudont@sigio.com>
   Changed at	Mon 07 May 2018 15:57:47
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	0f0a2281767a47c0ab4971d2b0dba5da10c6907b

   Comments

   LP#1243841 - Quiet remaining Make install warnings.
   We silence the following warnings:
   
   apachetools.c:179:15: warning: initialization discards 'const' qualifier
   from pointer target type [enabled by default]
   
   apachetools.c:181:8: warning: assignment discards 'const' qualifier from
   pointer target type [enabled by default]
   
   apachetools.c:183:8: warning: assignment discards 'const' qualifier from
   pointer target type [enabled by default]
   
   ./osrf_websocket_translator.c:541:9: warning: return makes integer from
   pointer without a cast [enabled by default]
   
   ./osrf_http_translator.c:300:25: warning: passing argument 1 of 'free'
   discards 'const' qualifier from pointer target type [enabled by default]
   
   Signed-off-by: Jason Stephenson <jason@sigio.com>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/gateway/apachetools.c
   • src/gateway/osrf_http_translator.c
   • src/gateway/osrf_websocket_translator.c

7. Change #5380

   Category	None
   Changed by	Galen Charlton <gmcohnoyoudont@equinoxinitiative.org>
   Changed at	Mon 07 May 2018 16:03:16
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	71720f639e00d0e457bc8f967f8060b579bc2882

   Comments

   LP#1243841: quiet a misleading indentation warning
   Adjusts a spaces-vs-tabs issue to fix the following compilation
   warning:
   
   osrf_prefork.c: In function ‘check_children’:
   osrf_prefork.c:1067:5: warning: this ‘if’ clause does not
   guard... [-Wmisleading-indentation]
        if( select_ret <= 0 ) // we're done here
        ^~
   osrf_prefork.c:1072:2: note: ...this statement, but the latter is
   misleadingly indented as if it is guarded by the ‘if’
     cur_child = forker->first_child;
     ^~~~~~~~~
   
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/libopensrf/osrf_prefork.c