Builder osrf-master-debian-6.00-x86_64 Build #76

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

scheduler

Steps and Logfiles:

1. git update ( 2 secs )
   1. stdio
2. Bootstrap via autogen './autogen.sh' skipped ( 0 secs )
   1. - no logs -
3. Bootstrap via autoreconf 'autoreconf -i' ( 6 secs )
   1. stdio
4. configure configure ( 13 secs )
   1. stdio
5. compile compile ( 1 secs )
   1. stdio
6. test test 138 tests 138 passed ( 5 secs )
   1. stdio
7. trial 14 tests passed ( 1 secs )
   1. stdio
   2. test.log
   3. problems
8. pylint pylint convention=254 error=28 fatal=7 refactor=279 warning=87 failed ( 5 secs )
   1. stdio
   2. convention
   3. error
   4. fatal
   5. refactor
   6. warning

Build Properties:

Forced Build Properties:

Responsible Users:

1. Jason Stephenson

   jasonohnoyoudont@sigio.com

Timing:

All Changes:

:

1. Change #5373

   Category	None
   Changed by	Jason Stephenson <jasonohnoyoudont@sigio.com>
   Changed at	Mon 07 May 2018 15:30:59
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	e72473d9c43a579ea64cb79fd410d37df23c3445

   Comments

   LP1340982: Ignore both 'comment' and '#comment' nodes in Settings Parse.
   Modify the XML2perl helper function in OpenSRF::Utils::SettingsParser
   to ignore comment nodes that have names of comment and #comment.
   
   To reproduce the bug:
   
   1. Stop OpenSRF services.
   
   2. Add a XML comment, any text betwen <!-- and -->, in the list of
   MARC templates in the opensrf.xml file.
   
   3. Restart OpenSRF services.
   
   4. In the staff client, go to Cataloging->Create New MARC Record.
   
   5. In the list of templates, you will #comment where you added the
   comment. (NOTE: I only tested with 1 comment.  Things may get worse
   with more than 1 comment.)
   
   6. There will be an error like the following in the
   open-ils.cat_stderr.log if you attempt to choose the #comment entry:
   
      Caught error from 'run' method: Exception: OpenSRF::EX::ERROR
      2018-02-18T11:24:30 OpenSRF::Application
      /usr/local/share/perl/5.22.1/OpenSRF/Application.pm:240 System
      ERROR: Unable to open MARC template file: HASH(0x2249928) :
   
   To test the fix:
   
   1. Leave the comments in the opensrf.xml file from before.
   
   2. Apply this commit, do make and make install for OpenSRF.
   
   3. Just to make sure, do make and make install for Evergreen.
   
   4. Repeat steps 3 and 4 from above.
   
   5. You should NOT see any templates named #comment.
   
   Signed-off-by: Jason Stephenson <jason@sigio.com>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

   Changed files

   • src/perl/lib/OpenSRF/Utils/SettingsParser.pm