Builder osrf-master-debian-6.00-x86_64 Build #54

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

scheduler

Steps and Logfiles:

1. git update ( 2 secs )
   1. stdio
2. Bootstrap via autogen './autogen.sh' skipped ( 0 secs )
   1. - no logs -
3. Bootstrap via autoreconf 'autoreconf -i' ( 6 secs )
   1. stdio
4. configure configure ( 13 secs )
   1. stdio
5. compile compile warnings ( 5 secs )
   1. stdio
   2. warnings (1)
6. test test 138 tests 138 passed ( 5 secs )
   1. stdio
7. trial 14 tests passed ( 0 secs )
   1. stdio
   2. test.log
   3. problems
8. pylint pylint convention=254 error=28 fatal=7 refactor=279 warning=87 failed ( 4 secs )
   1. stdio
   2. convention
   3. error
   4. fatal
   5. refactor
   6. warning

Build Properties:

Forced Build Properties:

Responsible Users:

1. Galen Charlton

   gmcohnoyoudont@equinoxinitiative.org
2. Mike Rylander

   mrylanderohnoyoudont@gmail.com

Timing:

All Changes:

:

1. Change #3885

   Category	None
   Changed by	Mike Rylander <mrylanderohnoyoudont@gmail.com>
   Changed at	Thu 16 Feb 2017 14:49:26
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	dbc54c646055d8840140eca7d2a1fa0760537688

   Comments

   LP#1652382: normalization of memcache keys in C code
   Memcache does not allow spaces in keys, so here we will actively strip them
   from any key we get from a caller.  Some callers are not very proactive about
   sending clean keys, and this patch prevents issues that can poison C-based
   OpenSRF service backends.
   
   Signed-off-by: Mike Rylander <mrylander@gmail.com>
   Signed-off-by: Kathy Lussier <klussier@masslnc.org>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
   Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

   Changed files

   • src/libopensrf/osrf_cache.c

2. Change #3886

   Category	None
   Changed by	Mike Rylander <mrylanderohnoyoudont@gmail.com>
   Changed at	Thu 16 Feb 2017 14:50:37
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	3277648c61f53ed8e36b9d51404d2b1979182c33

   Comments

   LP#1652382: Make use of the clean key just created
   Signed-off-by: Mike Rylander <mrylander@gmail.com>
   Signed-off-by: Kathy Lussier <klussier@masslnc.org>
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
   Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

   Changed files

   • src/libopensrf/osrf_cache.c

3. Change #3887

   Category	None
   Changed by	Galen Charlton <gmcohnoyoudont@equinoxinitiative.org>
   Changed at	Thu 16 Feb 2017 14:54:24
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	7524221ddbcdc2fd7780501f3fdf36ecc2e41cb0

   Comments

   LP#1652382: handle cases where supplied key is longer than 250 bytes
   With this patch, if cache clients want to use a key longer
   than the memcached text protocol limit of 250 bytes, the
   key is normalized to 'shortened_' + md5_hex(normalized_key).
   
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
   Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

   Changed files

   • src/libopensrf/osrf_cache.c
   • src/perl/lib/OpenSRF/Utils/Cache.pm

4. Change #3888

   Category	None
   Changed by	Galen Charlton <gmcohnoyoudont@equinoxinitiative.org>
   Changed at	Thu 16 Feb 2017 14:54:34
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	cbd252babff1d7c9c92db8d2b46f6172eb9a3845

   Comments

   LP#1652382: more improvements to cache key munging
   - teach osrfCacheRemove to clean keys
   - fix implict declaration compilation warning
   - account for fact that iscntrl('\0') returns true
   
   Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
   Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

   Changed files

   • src/libopensrf/osrf_cache.c