Builder osrf-master-debian-6.00-x86_64 Build #52

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

scheduler

Steps and Logfiles:

1. git update ( 2 secs )
   1. stdio
2. Bootstrap via autogen './autogen.sh' skipped ( 0 secs )
   1. - no logs -
3. Bootstrap via autoreconf 'autoreconf -i' ( 7 secs )
   1. stdio
4. configure configure ( 14 secs )
   1. stdio
5. compile compile ( 2 secs )
   1. stdio
6. test test 138 tests 138 passed ( 5 secs )
   1. stdio
7. trial 14 tests passed ( 1 secs )
   1. stdio
   2. test.log
   3. problems
8. pylint pylint convention=254 error=28 fatal=7 refactor=279 warning=87 failed ( 5 secs )
   1. stdio
   2. convention
   3. error
   4. fatal
   5. refactor
   6. warning

Build Properties:

Forced Build Properties:

Responsible Users:

1. Galen Charlton

   gmcohnoyoudont@esilibrary.com

Timing:

All Changes:

:

1. Change #3786

   Category	None
   Changed by	Galen Charlton <gmcohnoyoudont@esilibrary.com>
   Changed at	Thu 09 Feb 2017 10:35:40
   Repository	git://git.evergreen-ils.org/OpenSRF.git
   Project	OpenSRF
   Branch	master
   Revision	bd5fc631abee9b5afb844ce0c5a20cacfabe12fb

   Comments

   LP#1652122: fix infinite recursion in opensrf.system.method.all
   Under certain circumstances, calling opensrf.system.method.all on a
   Perl service can result in an infinite recursion when attempting to
   serialize an OpenSRF::Application object to JSON.  In particular,
   this was observed to happen when doing an introspection of
   the opensrf.settings service.
   
   This patch avoids the infinite recursion (and consequent memory
   leak) by ensuring that the 'session' key is slated for exclusion
   from serialization from OpenSRF::Application objects during
   bootstrapping.
   
   Note that the problem does not affect all Perl services; if a
   Perl service declares at least one streaming method, the auto-registration
   of the .atomic method will result in 'session'-stripping.
   
   This patch fixes a regression introduced in bug 1350457.
   
   To test
   -------
   [1] Run 'introspect opensrf.settings' via srfsh; observe
       that it never returns and that the opensrf.settings drone
       will grow in memory sized until killed.
   [2] Apply the patch, then repeat step 1. This time, the
       request should succeed.
   
   Signed-off-by: Galen Charlton <gmc@esilibrary.com>
   Signed-off-by: Mike Rylander <mrylander@gmail.com>

   Changed files

   • src/perl/lib/OpenSRF/System.pm